> > I could be reading this wrong, but it looks like > > DP83826_CFG_DAC_MINUS_DEFAULT actually means leave the value > > unchanged? Is there anything guaranteeing it does in fact have the > > default value in the hardware? > > > > Andrew > > Yes, the datasheet clearly states the default/reset values of both > registers VOD_CFG1 & VOD_CFG2 which are : > - cfg_dac_minus : 30h > - cfg_dac_plus : 10h And the device is actually and always reset by Linux when the driver loads? Anything the bootloader has done, or a previous kernel, will be cleared? Please add this explanation to the commit message. I'm being pedantic because we have had problems like this in the past. If a register was not actually set back to the default value, the bootloader set it to some other value, the board can work fine. Then a board can came along which the bootloader set the wrong value, and the default is actually needed. Fixing the driver to actually enforce the default breaks boards... Andrew
