On Tue, Jan 27, 2015 at 07:35:09PM +0100, Stefan Wahren wrote:
> > Mark Brown <broonie@xxxxxxxxxx> hat am 27. Januar 2015 um 01:16 geschrieben:
> > > okay i understand. But doesn't it need a extra driver to set the switching
> > > frequency because of the new compatible string?
> > I don't understand this bit at all, sorry.
> Sebastian suggested a new sub-node in the devicetree:
> powerpll {
> compatible = "fsl,imx28-power-pll"
> #clock-cells = <0>;
> clock-frequency = <12345>;
> }
> and i think that the new compatible string needs a separate driver to take care
> of the switching frequency.
I can see that this has been suggested, what I can't understand is why
we would wish to do this but I am missing some context here which may
make it all perfectly clear.
> Or is it okay to leave the handling of the switching frequency in the mxs-power
> driver?
Unless the clock is exposed externally to the regulator either as an
input or an output I'm not sure I see any benefit but I'm possibly
missing something here. It does sound like there might be a separate
clock IP or something?
> Btw if we add a new node to set switching frequency, i think it would be better
> to describe the dc-dc convertor and not the pll:
> dcdc {
> compatible = "fsl,imx28-dcdc"
> frequency = <12345>;
> }
> What do you think?
Yes, just adding a new property on the regulator node with all the other
properties seems sensible (we've just gained some helpers which make it
fairly straightforward to do this).
Attachment:
signature.asc
Description: Digital signature
