On Tue, Jan 27, 2015 at 11:13:08AM -0800, Sören Brinkmann wrote:
> On Tue, 2015-01-27 at 09:20AM -0600, Felipe Balbi wrote:
> > On Mon, Jan 26, 2015 at 05:45:29PM -0800, Soren Brinkmann wrote:
> > > A reset through a GPIO is optional. Don't fail probing when it is
> > > missing.
> > >
> > > Reported-by: Andreas Färber <afaerber@xxxxxxx>
> > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
> > > ---
> > > Hi Andreas,
> > >
> > > does this do the trick?
> > >
> > > Thanks,
> > > Sören
> > >
> > > drivers/usb/phy/phy-generic.c | 6 ++----
> > > 1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
> > > index dd05254241fb..a73d4c738f0b 100644
> > > --- a/drivers/usb/phy/phy-generic.c
> > > +++ b/drivers/usb/phy/phy-generic.c
> > > @@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,
> > >
> > > if (err == -EPROBE_DEFER)
> > > return -EPROBE_DEFER;
> > > - if (err) {
> > > - dev_err(dev, "Error requesting RESET GPIO\n");
> > > - return err;
> > > - }
> > > + if (err)
> > > + nop->gpiod_reset = NULL;
> >
> > there's a better patch to use gpiod_get_optional(), instead.
>
> Great, apparently that wasn't in linux-next yesterday. I'll give it a
> shot once it arrives there.
It's still under discussion ;-)
--
balbi
Attachment:
signature.asc
Description: Digital signature
