On 2024-02-06 19:58:50, Konrad Dybcio wrote:
> On 21.01.2024 23:33, Marijn Suijten wrote:
> > Add the pinctrl states for SDC1 and use them on sdhc_1.
> >
> > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > ---
>
> [...]
>
>
> > @@ -840,6 +890,11 @@ sdhc_1: mmc@7824900 {
> > <&gcc GCC_SDCC1_APPS_CLK>,
> > <&rpmcc RPM_SMD_XO_CLK_SRC>;
> > clock-names = "iface", "core", "xo";
> > +
> > + pinctrl-names = "default", "sleep";
> > + pinctrl-0 = <&sdc1_on_state>;
> > + pinctrl-1 = <&sdc1_off_state>;
>
> -names should go last
Per the cover letter:
- Moved pinctrl-names before pinctrl-N (Konrad);
You explicitly requested this in https://lore.kernel.org/linux-arm-msm/60a40ace-d4e9-df74-88f9-4354d80efaac@xxxxxxxxxx/#t
but we also backtracked on it somewhat for consistency with other -names, and the general state of this file.
Maybe we should apply v1 of this specific patch?
- Marijn
