On 06/02/2024 14:30, Neil Armstrong wrote: > Hi, > > On 06/02/2024 14:22, Krzysztof Kozlowski wrote: >> On 06/02/2024 14:12, Marc Gonzalez wrote: >>> From: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >>> >>> The fbx8am boards are based on the Amlogic Meson G12A S905X2 SoC, >>> and the SEI510 board design. >>> >>> Signed-off-by: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >>> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> >>> --- >>> Request For Comments to spot obvious mistakes before formal submission >>> NB: on IRC, narmstrong mentioned: >>>> adding dtbos for variants seems to be the new preferred way to handle such case >>>> the fdtoverlay utility works well for this case >> >> Please run scripts/checkpatch.pl and fix reported warnings. Some >> warnings can be ignored, but the code here looks like it needs a fix. >> Feel free to get in touch if the warning is not clear. > > I don't have checkpatch errors, I'm running with `--strict --terse`. I easily see 2 warnings, where one is relevant, with or without --strict. Best regards, Krzysztof
