On 06/02/2024 14:22, Krzysztof Kozlowski wrote: > On 06/02/2024 14:12, Marc Gonzalez wrote: > >> From: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >> >> The fbx8am boards are based on the Amlogic Meson G12A S905X2 SoC, >> and the SEI510 board design. >> >> Signed-off-by: Pierre-Hugues Husson <phhusson@xxxxxxxxxx> >> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> >> --- >> Request For Comments to spot obvious mistakes before formal submission >> NB: on IRC, narmstrong mentioned: >>> adding dtbos for variants seems to be the new preferred way to handle such case >>> the fdtoverlay utility works well for this case > > Please run scripts/checkpatch.pl and fix reported warnings. Some > warnings can be ignored, but the code here looks like it needs a fix. > Feel free to get in touch if the warning is not clear. Hello Krzysztof, The only checkpatch warnings are: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? This patch is modeled after another patch for a similar board. Which warning did you think required attention? Regards
