Re: [PATCH V4 0/2] pwm: Add GPIO PWM driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Feb 04, 2024 at 23:08:49 +0100, Stefan Wahren wrote:
> Add a software PWM which toggles a GPIO from a high-resolution timer.
> 
> Recent discussions in the Raspberry Pi community revealt that a lot
> of users still use MMIO userspace tools for GPIO access. One argument
> for this approach is the lack of a GPIO PWM kernel driver. So this
> series tries to fill this gap.
> 
> This continues the work of Vincent Whitchurch [1], which is easier
> to read and more consequent by rejecting sleeping GPIOs than Nicola's
> approach [2].
> 
> The work has been tested on a Raspberry Pi 3 B+ and a cheap logic
> analyzer.

I recently came across this series and I have to say that it will sure be
a nice to have feature to be able to use any GPIO as a PWM.

However, just a minor suggestion is that we should make sure it's well
documented how to actually use this. It would be much appreciated if you
could include some basic documentation of a few sysfs commands or any
userspace library that you used to test what you've mentioned above.

Maybe add another patch for this page?
https://docs.kernel.org/driver-api/pwm.html#using-pwms-with-the-sysfs-interface

This will ensure people know about this feature and will actually be
able to use it.

-- 
Best regards,
Dhruva Gole <d-gole@xxxxxx>




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux