On Sat, 3 Feb 2024 at 08:00, Chukun Pan <amadeus@xxxxxxxxxx> wrote: > > Hi, Bjorn > > That sounds good, but do we have any one of those boards that should > > reference &ipq6018_l2? Could make plug it into the sdhci node on some > > board? > > Actually I have an ipq6010 sdcard device with pmic, which needs to > reference ipq6018_l2. Also on the downstream qsdk kernel, the sdhc > node writes 'vqmmc-supply = <&ipq6018_l2>;' by default. > > > Essentially, why is it needed upstream, when there are no user? > > Most ipq60xx devices have pmic chips, including some ipq6000 devices, > while another ipq6000 devices do not have the pmic chips. So it does not > mean there are no users but the supply is board specific. Maybe we should > move the mp5496 node outside of ipq6018.dtsi. Yes, please. In the end, mp5496 is not a part of the SoC. -- With best wishes Dmitry