On 26.11.2023 18:34, Jonathan Cameron wrote:
On Tue, 14 Nov 2023 22:05:33 +0200
Alisa-Dariana Roman <alisadariana@xxxxxxxxx> wrote:
Unlike the other AD719Xs, AD7194 has configurable differential
channels. The default configuration for these channels can be changed
from the devicetree.
The default configuration is hardcoded in order to have a stable number
of channels.
Also modify config AD7192 description for better scaling.
Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
Not directly related to this patch (which looks fine to me)
but any idea why 3db_frequency_available is not using read_avail?
Seems sensible to convert it over given all the other cases are using that
and it will allow dropping at least some of the attributes infrastructure
for some devices.
Thank you very much for the feedback!
I actually tried then to use read_avail for the 3db frequencies, but it
required a greater rework. If I remember correctly, the four possible
frequency choices need to be stored in the ad7192_state for it to work.
Should I add a patch with these changes?
Kind regards,
Alisa-Dariana Roman
