> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Wednesday, January 31, 2024 12:18 AM > To: Ding, Shenghao <shenghao-ding@xxxxxx> > Cc: conor+dt@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > andriy.shevchenko@xxxxxxxxxxxxxxx; Lu, Kevin <kevin-lu@xxxxxx>; Xu, Baojun > <baojun.xu@xxxxxx>; devicetree@xxxxxxxxxxxxxxx; P O, Vijeth <v- > po@xxxxxx>; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; pierre- > louis.bossart@xxxxxxxxxxxxxxx; 13916275206@xxxxxxx; Chawla, Mohit > <mohit.chawla@xxxxxx>; linux-sound@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxx; soyer@xxxxxx; Huang, > Jonathan <jkhuang3@xxxxxx>; tiwai@xxxxxxx; Djuandi, Peter > <pdjuandi@xxxxxx>; McPherson, Jeff <j-mcpherson@xxxxxx>; Navada > Kanyana, Mukund <navada@xxxxxx>; Mark Brown <broonie@xxxxxxxxxx> > Subject: Re: [EXTERNAL] Re: [PATCH v2 4/4] ASoc: dt-bindings: PCM6240: > Add initial DT binding > > On 29/01/2024 05: 43, Ding, Shenghao wrote: >> >> On Fri, Jan 26, 2024 at > 09: 27: 47AM +0100, Krzysztof Kozlowski wrote: >>> On 26/01/2024 04: 58, > Shenghao Ding wrote: >> >>>> + - if: >>>> + properties: > ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas > Instruments. > Do not click links or open attachments unless you recognize the source of > this email and know the content is safe. > > ZjQcmQRYFpfptBannerEnd > On 29/01/2024 05:43, Ding, Shenghao wrote: > >> > >> On Fri, Jan 26, 2024 at 09:27:47AM +0100, Krzysztof Kozlowski wrote: > >>> On 26/01/2024 04:58, Shenghao Ding wrote: > >> > >>>> + - if: > >>>> + properties: > >>>> + compatible: > >>>> + contains: > >>>> + enum: > >>>> + - ti,pcm1690 > >>>> + then: > >>>> + properties: > >>>> + reg: > >>>> + items: > >>>> + minimum: 0x4c > >>>> + maximum: 0x4f > >> > >>> Nothing improved. > >> > >> Shenghao explained what what this is doing - I'm not sure what the > >> actual problem is here? It's an actual restriction on the values that are > valid. > > > > Hi, Krzysztof. May I have the privilege to petition on behalf of my > > customers? They want to keep these if branches and the i2c address in > > yaml file. As you know, most of my customers used to make mistakes and > > confuse with the i2c address. Listing them here can help them to get the > information easily. > > To which cases this exception will apply? Your patches, all TI? > Some AI customers usually like to try some innovative projects, such as their multiple-slot TDM devices with serval different ADCs or DAC on different i2c buses. Traditional driver code really can't meet their requirements. > Bindings are not supposed to be so detailed to create DTS out if it, because it > makes them more difficult to maintain. Such amount of > if:then: makes it trickier, for no real gain. > Accept Best regards, Shenghao Ding
