Hey, On Tue, Jan 30, 2024 at 05:26:50PM +0530, Naresh Solanki wrote: > voltage-divider is always an iio consumer at the same time it is > optionally an iio provider. > Hence add #io-channel-cells > Also update example. > > Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx> > --- > .../bindings/iio/afe/voltage-divider.yaml | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml > index dddf97b50549..98fec8548cc3 100644 > --- a/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml > +++ b/Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml > @@ -39,6 +39,13 @@ properties: > description: | > Channel node of a voltage io-channel. > > + '#io-channel-cells': > + description: > + In addition to consuming the measurement services of a voltage output > + channel the voltage divider can act as a provider of measurement > + services to other devices. Did you miss: https://lore.kernel.org/all/20240127165542.6eeb23e9@jic23-huawei/ Where I said that I would like to have an example of where this would be used in the description? Peter gave a good example that you can draw on. > + const: 1 > + > output-ohms: > description: > Resistance Rout over which the output voltage is measured. See full-ohms. > @@ -75,12 +82,17 @@ examples: > spi-max-frequency = <1000000>; > }; > }; > - sysv { > + p12v_vd: sysv { > compatible = "voltage-divider"; > io-channels = <&maxadc 1>; > + #io-channel-cells = <1>; > > /* Scale the system voltage by 22/222 to fit the ADC range. */ > output-ohms = <22>; > full-ohms = <222>; /* 200 + 22 */ > }; Blank line here please. Thanks, Conor. > + iio-hwmon { > + compatible = "iio-hwmon"; > + io-channels = <&p12v_vd 0>; > + }; > ... > > base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a > -- > 2.42.0 >
Attachment:
signature.asc
Description: PGP signature
