Hi, Bjorn > Subject and commit message says "enable", but this says disable. Could > you change this to "Add" instead? Thanks for your suggestion, I will change this to "Add". > Do you have a patch for any board where this is actually enabled? > Perhaps you missed a 3rd patch that enables this and uses the ipq6018_l2 > regulator you add in patch 1? Some ipq6000 devices do not have pmic chips, resulting in l2 being unavailable. So vqmmc-supply should be configured in the dts of each specific device. As Robert suggested, the ipq6018_l2 node is used for the device dts reference. Thanks, Chukun -- 2.25.1