On Wed, Jan 24, 2024 at 07:31:34AM +0100, Krzysztof Kozlowski wrote: > On 24/01/2024 05:25, Bjorn Andersson wrote: > > +# Allow either power-domains or vdd-gfx-supply, not both > > +oneOf: > > + - required: > > + - power-domains > > + - required: > > + - vdd-gfx-supply > > + - not: > > + anyOf: > > + - required: > > + - power-domains > > + - required: > > + - vdd-gfx-supply > > I don't fully understand what you want to achieve here. If only "allow > either", so not a "require either", then simpler: > > https://lore.kernel.org/all/20230118163208.GA117919-robh@xxxxxxxxxx/ > As discussed in v2, power-domains is currently an optional property in this binding and I'm adding vdd-gfx-supply as an alternative to that. As it's optional, barely any of our platforms define the property, so requiring this would not be compatible with existing DT source. It's clear that this does not accurately represent the power situation for the block, so we should fix this. But I'd prefer to see that as a separate task. Implementation-wise, we need to figure how to consume multiple power-domains in the GPUCC drivers in Linux, because the correct definition seems to be to add both CX and GX/GFX domains here - and if we just add them to the DT node Linux will break. Regards, Bjorn
