On 1/22/24 12:10, Andy Yan wrote: > Hi Cristian: > > On 1/20/24 07:41, Cristian Ciocaltea wrote: >> On 1/19/24 21:38, Cristian Ciocaltea wrote: >>> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY >>> found on RK3588 SoC. >>> >>> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL >>> and eDP links. >>> >>> The HDMI link has been tested on Rock 5B and EVB1 boards. >> >> I missed to highlight there is no eDP support provided by the current >> implementation. Downstream kernel has a separate driver for that and at >> the moment I don't have the hardware to wire this up. >> >> Will include this statement in v2. > > The PHY is used for HDMI and eDP on rk3588, and should used be exclusively. > so I think should s/DP/eDP/ in all description. Right, will make this consistent. Thanks, Cristian
