On Tue, Jan 23, 2024 at 12:25:33PM +0100, Krzysztof Kozlowski wrote: > On 23/01/2024 12:14, Shenghao Ding wrote: > > PCM6240 driver implements a flexible and configurable setting for register > > and filter coefficients, to one, two or even multiple PCM6240 Family Audio > > chips. > So before you added dead code? No, please add a working code, so squash > the patches. This is a fairly normal way of adding completely new files that are split into multiple commits for whatever reason, and given that the main C file is 2600 lines and the header another couple of hundred I'm not going to object to something that makes them a bit easier to digest. This is especially true for a driver like this which is handling some hardware that's a bit interesting and therefore has more complicated code, it's not all big data tables like many ASoC drivers. It'd be even nicer to have things done a bit more incrementally in logical blocks but every little helps.
Attachment:
signature.asc
Description: PGP signature
