On Fri, 23 Jan 2015, Thomas Gleixner wrote: > On Thu, 22 Jan 2015, Lee Jones wrote: > > > This driver is used to enable System Configuration Register controlled > > External, CTI (Core Sight), PMU (Performance Management), and PL310 L2 > > Cache IRQs prior to use. > > I'm wondering how this is related to irq_chip, It doesn't really. At least, it doesn't make use of the framework. It was the most relevant subsystem. > but well, I don't mind it being parked here. Thanks Thomas. I was hoping for that response. > Though I really cannot say anything about this DT translation > machinery for a single sysconfig register, other than it looks > completely overengineered to me. I understnad where you're coming from, but don't all drivers just 'twiddle some register bits'? > The only technical comment I have is: shouldn't all the stuff except > the resume function be marked __init or is any of this required post > init? It's not common to mark functions invoked at and affter *_probe() as __init. At least, not as far as I'm aware. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
