On Mon, 22 Jan 2024 06:57:32 -0800 Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > On 1/22/24 00:47, marius.cristea@xxxxxxxxxxxxx wrote: > > From: Marius Cristea <marius.cristea@xxxxxxxxxxxxx> > > > > Adding support for Microchip PAC193X series of Power Monitor with > > Accumulator chip family. This driver covers the following part numbers: > > - PAC1931, PAC1932, PAC1933 and PAC1934 > > > > This device is at the boundary between IIO and HWMON (if you are > > looking just at the "shunt resistors, vsense, power, energy"). The > > device also has ADC internally that can measure voltages (up to 4 > > channels) and also currents (up to 4 channels). The current is measured as > > voltage across the shunt_resistor. > > > > I have started with a simple driver (this one that is more appropriate to be > > a HWMON) and willing to add more functionality later (like data buffering that > > Not sure I understand what you are trying to say here. This is obviously an iio > driver, not a hwmon driver. Any hwmon related concern is irrelevant. It's a left over comment / attempt to summarise the discussion of whether IIO or HWMON was a better home for a driver for this device. Based on current feature set that's not an obvious decision, but there are other planned features that fit better in IIO. > > Guenter >