Re: [PATCH v6 1/8] dt-bindings: adc: ad9467: add new io-backend property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 22 Jan 2024 17:01:57 +0100
Nuno Sá <noname.nuno@xxxxxxxxx> wrote:

> On Mon, 2024-01-22 at 09:37 -0600, Rob Herring wrote:
> > On Fri, Jan 19, 2024 at 11:15:54AM -0600, Rob Herring wrote:  
> > > 
> > > On Fri, 19 Jan 2024 17:00:47 +0100, Nuno Sa wrote:  
> > > > The ad9467 will make use of the new IIO backend framework which is a
> > > > provider - consumer interface where IIO backends provide services to
> > > > consumers. As such, and being this device a consumer,  add the new
> > > > generic io-backend property to the bindings.
> > > > 
> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
> > > > ---
> > > >  Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >   
> > > 
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > > 
> > > yamllint warnings/errors:
> > > 
> > > dtschema/dtc warnings/errors:
> > > /builds/robherring/dt-review-
> > > ci/linux/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml: io-backends:
> > > missing type definition  
> > 
> > Are you going to update the GH PR so I can apply adding io-backends?
> > 
> >   
> 
> Yes, I can do that. I was thinking you preferred to have the second user so I was
> planning in updating only after sending out that series (or Olivier if he ends up
> sending his series first).
> 
> Olivier already gave his ack in [1], but I guess you would also like Jonathan's ack
> on that PULL right?
> 
> Jonathan,
> would that be something you can do? The pull is in [2]... Maybe give your
> comments/review in there if any.

Looks like there is a comment on Rob still to address about io-backend-names.
Otherwise I'm fine with it.

J

> 
> 
> [2]: https://github.com/devicetree-org/dt-schema/pull/120
> [1]: https://lore.kernel.org/linux-iio/4b1ffdc4-edce-4a69-a30b-45c29741dc2c@xxxxxxxxxxx/
> 
> - Nuno Sá
> 






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux