On 23 January 2015 at 17:09, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > Am Freitag, den 23.01.2015, 16:14 +0530 schrieb Viresh Kumar: >> I haven't incorporated the comments given by Mark Brown as I had some doubts. >> @broonie: Is this what you wanted to mention earlier ? : http://pastebin.com/1RZTccmm >> > > I think we should work this out for the new bindings, as > voltage-tolerance is a completely bogus value. Yeah, that's what I was saying. I just wanted to confirm that I understood it clearly. And so didn't made the changes here. >> + - opp-microvolt: voltage in micro Volts > > Each OPP voltage should be defined by the triplet of minimum, > nominal/typical, maximum. This lets you specify exact tolerances in each > direction and should cover most use-cases. > > IMHO it would make sense to just define opp-microvolt as an array of > those 3 values, so the DT doesn't get bloated with a lot more > properties. > > A typical value for a CPU could then look like this: > opp-microvolt = <800000 850000 1100000> > > For devices without any tolerance you can just specify the same value > three times and be done with it: > opp-microvolt = <900000 900000 900000> Ok. >> + Optional properties: >> + - turbo-mode: Marks the volt-freq pair as turbo pair. >> + - status: Marks the node enabled/disabled. >> + - voltage-tolerance: Specify the CPU voltage tolerance in percentage. > > Please let's drop this. Yes, I did dropped it in the pastebin link I gave above. Thanks again for your feedback. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html