[...]
> + /*
> + * According to erratum 'ERR-7878951' Armada 38x SDHCI
> + * controller has different capabilities than the ones shown
> + * in its registers
> + */
> + host->caps = sdhci_readl(host, SDHCI_CAPABILITIES);
> + if (of_get_property(np, "no-1-8-v", NULL)) {
Please use of_property_read_bool(np, "no-1-8-v")
> + host->caps &= ~SDHCI_CAN_VDD_180;
> + host->mmc->caps &= ~MMC_CAP_1_8V_DDR;
Is SDHCI_CAN_VDD_330 always set elsewhere in this case?
> + } else
> + host->caps &= ~SDHCI_CAN_VDD_330;
If one branch in an if-else pair is braced, both sides should be (as
Documentation/CodingStyle says). Please brace the else case.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
