Re: [PATCH v5 2/3] dt-bindings: iio: light: Avago APDS9306

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22/1/24 20:21, Krzysztof Kozlowski wrote:
On 21/01/2024 06:17, Subhajit Ghosh wrote:
Adding device tree support for APDS9306 Ambient Light Sensor.
Updating datasheet hyperlinks.
Adding interrupt definition macro and header file.
Adding vdd-supply property.

Why? Do other devices have it?
Are you referring to vdd-supply? No, I guess, haven't checked actually.
If other devices don't have, can you suggest the best way to handle that?


  required:
@@ -33,6 +37,8 @@ required:
examples:
    - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
      i2c {
          #address-cells = <1>;
          #size-cells = <0>;
@@ -41,7 +47,8 @@ examples:
              compatible = "avago,apds9300";
              reg = <0x39>;
              interrupt-parent = <&gpio2>;
-            interrupts = <29 8>;
+            interrupts = <29 IRQ_TYPE_LEVEL_LOW>;

Separate change.
Understood.

Best regards,
Krzysztof

Regards,
Subhajit Ghosh





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux