On 21/01/2024 06:17, Subhajit Ghosh wrote: > Adding device tree support for APDS9306 Ambient Light Sensor. > Updating datasheet hyperlinks. > Adding interrupt definition macro and header file. > Adding vdd-supply property. Why? Do other devices have it? > required: > @@ -33,6 +37,8 @@ required: > > examples: > - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > i2c { > #address-cells = <1>; > #size-cells = <0>; > @@ -41,7 +47,8 @@ examples: > compatible = "avago,apds9300"; > reg = <0x39>; > interrupt-parent = <&gpio2>; > - interrupts = <29 8>; > + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; Separate change. Best regards, Krzysztof