On 20/01/2024 14:55, Tim Lunn wrote: > Rockchip RK809 shares the same audio codec block as the rk817 mfd, and What rk817 has anything to do with this? > is compatible with the existing rk817_codec driver. This patch Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > introduces the clock required for the audio codec. > > This clock provides the I2S master clock for the audio data. The codec > driver finds the clock by the name "mclk" and will fail to register if > this is missing. Clock-names is kept here to keep compatibility with the > exisitng driver ABI and also to be consistent with the rk817 binding. Typo. Also, what consistency with rk817 driver? I really do not understand which problem you are solving here. Best regards, Krzysztof
