Hello Jerome, On Wed, Jan 17, 2024 at 11:16:31AM +0100, Jerome Brunet wrote: > On Wed 17 Jan 2024 at 10:58, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > [[PGP Signed Part:Undecided]] > > Hello, > > > > On Fri, Dec 22, 2023 at 12:16:50PM +0100, Jerome Brunet wrote: > >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> index a1d382aacb82..eece390114a3 100644 > >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> @@ -21,23 +21,35 @@ properties: > >> - amlogic,meson-g12a-ee-pwm > >> - amlogic,meson-g12a-ao-pwm-ab > >> - amlogic,meson-g12a-ao-pwm-cd > >> - - amlogic,meson-s4-pwm Either I still didn't grasp all the details of this change, or removing amlogic,meson-s4-pwm in this commit is wrong. > >> + deprecated: true > >> - items: > >> - const: amlogic,meson-gx-pwm > >> - const: amlogic,meson-gxbb-pwm > >> + deprecated: true > >> - items: > >> - const: amlogic,meson-gx-ao-pwm > >> - const: amlogic,meson-gxbb-ao-pwm > >> + deprecated: true > >> - items: > >> - const: amlogic,meson8-pwm > >> - const: amlogic,meson8b-pwm > >> + deprecated: true > > > > I think deprecating the old binding and adding a new compatible should > > be done in two commits. > > Hi Uwe, > > There was the same comment on v3 and Krzysztof said it should be done > like this: > > https://lore.kernel.org/linux-pwm/e127dcef-3149-443a-9a8c-d24ef4054f09@xxxxxxxxxx > > I tend to agree with Krzysztof on this but, as I previously said, > I don't really mind one way or the other. Just have to pick one. Ah, so the machines that used amlogic,meson-g12a-ee-pwm before are supposed to use amlogic,meson-g12-pwm-v2 now. With that understood I agree to you and Krzysztof. I wonder if me not understanding that is a sign that the commit log isn't optimal (or if it's only that I didn't properly read it :-). Now that I understood the change better, the commit log is understandable, but maybe still make it a bit more explicit that it introduces a new way to formalize already supported hardware. Something like: dt-bindings: pwm: amlogic: Add a new binding for meson8 pwm types The binding that is used up to now describe which input the PWM channel multiplexer should pick among its possible parents, which are hardcoded in the driver. This isn't a good binding in the sense that it should describe hardware but not usage. Add a new binding deprecating the old one that uses clocks in a better way and how clocks are usually used today: The list of clocks describe the inputs of the PWM block as they are realised in hardware. So deprecate the old bindings and introduce a compatible per SoC family to replace these. I think I'd understand that better, but that might be because I wrote it and it's subjective? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
