On Wed 17 Jan 2024 at 10:58, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > [[PGP Signed Part:Undecided]] > Hello, > > On Fri, Dec 22, 2023 at 12:16:50PM +0100, Jerome Brunet wrote: >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> index a1d382aacb82..eece390114a3 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> @@ -21,23 +21,35 @@ properties: >> - amlogic,meson-g12a-ee-pwm >> - amlogic,meson-g12a-ao-pwm-ab >> - amlogic,meson-g12a-ao-pwm-cd >> - - amlogic,meson-s4-pwm >> + deprecated: true >> - items: >> - const: amlogic,meson-gx-pwm >> - const: amlogic,meson-gxbb-pwm >> + deprecated: true >> - items: >> - const: amlogic,meson-gx-ao-pwm >> - const: amlogic,meson-gxbb-ao-pwm >> + deprecated: true >> - items: >> - const: amlogic,meson8-pwm >> - const: amlogic,meson8b-pwm >> + deprecated: true > > I think deprecating the old binding and adding a new compatible should > be done in two commits. Hi Uwe, There was the same comment on v3 and Krzysztof said it should be done like this: https://lore.kernel.org/linux-pwm/e127dcef-3149-443a-9a8c-d24ef4054f09@xxxxxxxxxx I tend to agree with Krzysztof on this but, as I previously said, I don't really mind one way or the other. Just have to pick one. > >> + - const: amlogic,meson8-pwm-v2 >> + - items: >> + - enum: >> + - amlogic,meson8b-pwm-v2 >> + - amlogic,meson-gxbb-pwm-v2 >> + - amlogic,meson-axg-pwm-v2 >> + - amlogic,meson-g12-pwm-v2 >> + - const: amlogic,meson8-pwm-v2 >> + - const: amlogic,meson-s4-pwm > > Best regards > Uwe -- Jerome
