On 12.01.2024 16:17, Bryan O'Donoghue wrote: > On 12/01/2024 14:22, Krishna chaitanya chundru wrote: >> CPU-PCIe path consits for registers PCIe BAR space, config space. >> As there is less access on this path compared to pcie to mem path >> add minimum vote i.e GEN1x1 bandwidth always. >> >> In suspend remove the cpu vote after register space access is done. >> >> Fixes: c4860af88d0c ("PCI: qcom: Add basic interconnect support") > > If this patch is a Fixes then don't you need the accompanying dts change as a parallel Fixes too ? > > i.e. without the dts update - you won't have the nodes in the dts to consume => applying this code to the stable kernel absent the dts will result in no functional change and therefore no bugfix. The Fixes tag denotes a bug fix, its use for backport autosel is just a nice "coincidence". Fixing a lack of a required icc path and having to rely on BL leftovers / keepalive bus settings is definitely worth this tag in my eyes. Konrad