On 12/01/2024 16:50, Krzysztof Kozlowski wrote: > On 12/01/2024 16:31, Frank Li wrote: >> I review previous comments. The previous RFC patches and I just want I3C >> expert review to check if there are comments about whole software >> architecture. Of course, thank you for your comments about "slave". >> >> Go back this binding doc problem. >> >> "No, it's the same device. >> >> Anyway, this was not tested. >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time, thus I will skip this patch entirely till you follow >> the process allowing the patch to be tested. >> >> Please kindly resend and include all necessary To/Cc entries. >> " >> >> It is the same devices, work at difference mode (master and target). >> what's do you want to change to? >> >> Copy to new file like pci/pci-ep? all context is the same, except for >> compatible string. >> > > Apologies, I mixed up a bit patches, so this was not obvious. I meant > this comment: > > https://lore.kernel.org/all/20231017201404.GA2570433-robh@xxxxxxxxxx/ > > There is no indication in your commit msg that these concerns were > addressed. And here: https://lore.kernel.org/all/6110c58a-8003-4889-9a4b-6a7d1821c00e@xxxxxxxxxx/ Best regards, Krzysztof
