On Mon, Jan 08, 2024 at 03:54:14PM +0200, Tomer Maimon wrote:
> The NPCM8XX clock driver uses 25Mhz external clock, therefor adding
therefore
> refclk property.
'refclk' is not a property.
>
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
> .../bindings/clock/nuvoton,npcm845-clk.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> index b901ca13cd25..0b642bfce292 100644
> --- a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> @@ -21,6 +21,14 @@ properties:
> reg:
> maxItems: 1
>
> + clocks:
> + items:
> + - description: 25Mhz referance clock
reference
> +
> + clock-names:
> + items:
> + - const: refclk
> +
> '#clock-cells':
> const: 1
> description:
> @@ -30,12 +38,20 @@ properties:
> required:
> - compatible
> - reg
> + - clocks
> + - clock-names
New required properties are an ABI break. That's fine if you explain why
that's okay in the commit msg.
> - '#clock-cells'
>
> additionalProperties: false
>
> examples:
> - |
> + refclk: refclk-25mhz {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
Examples don't need to show providers.
> +
> ahb {
> #address-cells = <2>;
> #size-cells = <2>;
> --
> 2.34.1
>
