Hi Rob, Thanks for your comment. On Mon, 8 Jan 2024 at 23:09, Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Mon, 08 Jan 2024 15:54:14 +0200, Tomer Maimon wrote: > > The NPCM8XX clock driver uses 25Mhz external clock, therefor adding > > refclk property. > > > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > > --- > > .../bindings/clock/nuvoton,npcm845-clk.yaml | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.example.dtb: clock-controller@f0801000: 'clocks' is a required property > from schema $id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.example.dtb: clock-controller@f0801000: 'clock-names' is a required property > from schema $id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240108135421.684263-2-tmaimon77@xxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > probably I missed adding the clock and clock-names to the example node, will be fixed next version
