Re: [PATCH v3] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range min/maxItems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 3, 2024 at 6:39 PM Rob Herring <robh@xxxxxxxxxx> wrote:

> Yes. There's not really an immediate fix I see. The issue is in the
> if/then schemas we don't have enough information to know the type of
> fsl,tmu-range. To work correctly, it needs to be transformed to:
>
> fsl,tmu-range:
>   items:
>     minItems: 7
>     maxItems: 7

Is this a typo?

minItems cannot be 7.

- lx2160a has two fsl,tmu-range entries
- imx8mq has four fsl,tmu-range entries.

> This goes back to everything gets encoded into a 2 dim matrix, but the
> schemas try to hide this encoding. My plan here is to eventually drop
> doing that and decode properties to their correct type. That will drop
> a lot of the fixups. I have patches to do that, but then it has other
> corner cases.
>
> So short term, I'd just leave things such that they don't warn or just
> drop the conditional.

Is my v3 proposal good then?
https://patchwork.kernel.org/project/linux-pm/patch/20230928222130.580487-1-festevam@xxxxxxxxx/

It fixes all fsl,tmu-range warnings





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux