On Thu, Sep 28, 2023 at 07:21:30PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@xxxxxxx> > > The number of fsl,tmu-range entries vary among the several NXP SoCs. > > - lx2160a has two fsl,tmu-range entries (fsl,qoriq-tmu compatible) > - imx8mq has four fsl,tmu-range entries. (fsl,imx8mq-tmu compatible) > - imx93 has seven fsl,tmu-range entries. (fsl,qoriq-tmu compatible) > > Change minItems and maxItems accordingly. > > This fixes the following schema warning: > > imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed: > [2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long > > Signed-off-by: Fabio Estevam <festevam@xxxxxxx> tbh, this seems like a situation where per compatible constraints should be added, since each of the devices listed above has different requirements. Thanks, Conor. > --- > Changes since v1: > - Adjust min/maxItems to cover all NXP SoCs. > > Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml > index ee4780f186f9..60b9d79e7543 100644 > --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml > @@ -36,7 +36,8 @@ properties: > description: | > The values to be programmed into TTRnCR, as specified by the SoC > reference manual. The first cell is TTR0CR, the second is TTR1CR, etc. > - minItems: 4 > + minItems: 2 > + maxItems: 7 > > fsl,tmu-calibration: > $ref: /schemas/types.yaml#/definitions/uint32-matrix > -- > 2.34.1 >
Attachment:
signature.asc
Description: PGP signature