> A side note: in all files where you use ioport.h check if you actually included it. > > ... > > > -#include <linux/types.h> > > -#include <linux/list.h> > > #include <linux/bits.h> > > #include <linux/err.h> > > +#include <linux/ioport.h> > > +#include <linux/list.h> > > +#include <linux/types.h> > > Fine, but no. This file is still not using the iopoll.h. > See the forward declarations below? It should be there. > > > struct fwnode_operations; > > struct device; > > ... > > > --- a/include/linux/property.h > > +++ b/include/linux/property.h > > Same comment(s) here. I don't fully follow. Are you suggesting adding an explicit 'struct resource' declaration as opposed to including ioport.h? If so, why? To reduce scope?