On 27/12/2023 13:05, Josua Mayer wrote: >>> + - description: Armada 380 SoC >>> + items: >>> + - const: marvell,armada380 >>> + >> Thanks for the conversion. I think this is still not what we want. The >> main problem is of course in the original binding, not your conversion. >> Compatible armada380 above alone is not correct. This is SoC and SoC >> compatible cannot be used alone, because it is not specific enough to >> differentiate boards. Same applies for further lists, which I removed >> from the quote, for the same reasons. >> >> What we could do here is to fix this instead of pure conversion: >> 1. Add this binding file with new compatibles for existing boards and >> drop the TXT file, with explanation that you actually document properly >> all existing board compatibles. > So - we could add a boilerplate yaml with zero boards in conversion commit, > and then add new or existing boards through separate commits? boilerplate YAML file is kind of useless. It's like writing new driver with adding empty C file and Makefile entry. I understand you want to split logical items, but there is no logical action as "empty binding file". > > I feel that collecting / fixing the compatibles for all a38x based > boards might be a lot of effort. > Would it be acceptable to start with the few that I know / use myself? > In addition to those already submitted I could include > armada-388-helios4.dts. Yes, it's fine. > >> 2. Add compatibles to existing DTS. > For boards I do not know / using codenames - is there a template / > generic description string? >> 3. Add your new board compatibles. >> >> At least this is what I would do for typical cases, but as I said >> before, Marvell here is in some surprising limbo state. > Best regards, Krzysztof
