On 26/12/2023 19:11, Josua Mayer wrote: > Convert the existing txt binding for armada-38x socs to DT schema > format. ... > +--- > +$id: http://devicetree.org/schemas/arm/marvell/armada-38x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell Armada 38x Platforms > + > +maintainers: > + - Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + > + - description: Armada 380 SoC > + items: > + - const: marvell,armada380 > + Thanks for the conversion. I think this is still not what we want. The main problem is of course in the original binding, not your conversion. Compatible armada380 above alone is not correct. This is SoC and SoC compatible cannot be used alone, because it is not specific enough to differentiate boards. Same applies for further lists, which I removed from the quote, for the same reasons. What we could do here is to fix this instead of pure conversion: 1. Add this binding file with new compatibles for existing boards and drop the TXT file, with explanation that you actually document properly all existing board compatibles. 2. Add compatibles to existing DTS. 3. Add your new board compatibles. At least this is what I would do for typical cases, but as I said before, Marvell here is in some surprising limbo state. Best regards, Krzysztof
