Hi, Jason: On Fri, 2023-12-22 at 12:52 +0800, Jason-JH.Lin wrote: > To support secure video path feature, GCE have to read/write > registgers > in the secure world. GCE will enable the secure access permission to > the > HW who wants to access the secure content buffer. > > Add CMDQ secure mailbox driver to make CMDQ client user is able to > sending their HW settings to the secure world. So that GCE can > execute > all instructions to configure HW in the secure world. > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx> > --- [snip] > + > +static u32 cmdq_sec_get_cookie(struct cmdq_sec *cmdq, u32 idx) > +{ > + return *(u32 *)(cmdq->shared_mem->va + > + CMDQ_SEC_SHARED_THR_CNT_OFFSET + idx * sizeof(u32)); > +} cmdq_sec_get_cookie() is called in normal context not irq context, so we could allow a function call into TEE to query cookie even though the function call would take time. Therefore, it's not necessary to use a cmdq command to copy cookie value into share memory. Regards, CK