On 24/12/2023 05:34, Frank Li wrote: > On Sat, Dec 23, 2023 at 07:43:01PM +0100, Krzysztof Kozlowski wrote: >> On 23/12/2023 04:46, Frank Li wrote: >>> On Thu, Dec 21, 2023 at 04:50:33PM -0600, Rob Herring wrote: >>>> On Wed, Dec 20, 2023 at 04:36:09PM -0500, Frank Li wrote: >>>>> snps,dw-pcie.yaml already have reg and reg-name information. Needn't >>>>> duplciate here. >>>>> >>>>> Acked-by: Rob Herring <robh@xxxxxxxxxx> >>>>> Signed-off-by: Frank Li <Frank.Li@xxxxxxx> >>>>> --- >>>>> >>>>> Notes: >>>>> Change from v4 to v5 >>>>> - add Rob's Acked >>>> >>>> Err, that was intended for patch 9, not this one. This patch should be >>>> dropped. >>> >>> Sorry, will correct it. >>> >>> Actually I want to move it under Allof >>> >>> if compatiable string (A, B, C...) >>> then >>> reg-names: >>> -const: dbi >>> -const: config >>> >>> Differece SOC have difference reg-names required list. If split it, it >>> will be easy when add new SOC. Needn't change two place. >>> >>> Let me update at next version. >>> >> >> This patch should be dropped. Why do you remove entries from top-level? >> Are they defined in other schema? > > pci/snps,dw-pcie.yaml already define it. Indeed I see you wrote it in commit msg. However snps,dwc-pcie has it in an unconstrained way. Nothing in commit msg suggests there are constrains somewhere. Best regards, Krzysztof
