Hi Peng,
On Fri, Dec 15, 2023 at 12:52 PM Peng Fan (OSS) <peng.fan@xxxxxxxxxxx> wrote:
In this example, as it is not intended to reflect any specific hardware,
use the latest canonical naming:
> +
> + scmi_pinctrl: protocol@19 {
> + reg = <0x19>;
> + #pinctrl-cells = <0>;
> +
> + i2c2-pins {
> + groups = "i2c2_a", "i2c2_b";
groups = "g_i2c2_a", "g_i2c2_b";
> + function = "i2c2";
function = "f_i2c2";
> + };
> +
> + mdio-pins {
> + groups = "avb_mdio";
groups = "g_avb_mdio";
> + drive-strength = <24>;
> + };
> +
> + keys_pins: keys-pins {
> + pins = "GP_5_17", "GP_5_20", "GP_5_22", "GP_2_1";
pins = "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_2_1";
These names look odd to me, like these are actually groups
with pins 5..17 etc. Should it be groups = "g_gpio_5_17" etc?
Yours,
Linus Walleij
