Il 20/12/23 11:38, William-tw Lin ha scritto:
Add dts node for socinfo retrieval for the following projects: MT8173, MT8183, MT8186, MT8192, MT8195
arm64: dts: mediatek: Add socinfo efuses to MT8173/83/96/92/95 SoCs Add efuse nodes for socinfo retrieval for MT8173, MT8183, MT8186, MT8192 and MT8195. ...because you're not adding a chipinfo node, but efuse nodes :-)
Signed-off-by: William-tw Lin <william-tw.lin@xxxxxxxxxxxx> --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 9 +++++++++ arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 +++++++++ arch/arm64/boot/dts/mediatek/mt8186.dtsi | 4 ++++ arch/arm64/boot/dts/mediatek/mt8192.dtsi | 8 ++++++++ arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 +++ 5 files changed, 33 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index c47d7d900f28..06916e60679a 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -590,6 +590,15 @@ reg = <0 0x10206000 0 0x1000>; #address-cells = <1>; #size-cells = <1>; + + socinfo_data1: socinfo-data1@40 {
Also, you don't need the phandles as those nodes will never be modified from board specific devicetree, nor assigned to any devicetree node. This means that you can go with just socinfo-data1@40 { reg ... } same for data2 and for all SoCs. Apart from that, looks good to me. Cheers, Angelo