On 09:28-20231218, Tony Lindgren wrote:
> * Nishanth Menon <nm@xxxxxx> [231215 16:00]:
> > On 09:32-20231114, Tony Lindgren wrote:
> > > - wkup_uart0: serial@2b300000 {
> > > - compatible = "ti,am64-uart", "ti,am654-uart";
> > > - reg = <0x00 0x2b300000 0x00 0x100>;
> > > - interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> > > + target-module@2b300000 {
> >
> > should be target-module@2b300050 to match up with reg?
>
> It's best to use the target-module IO range here, not the first reg.
> The first reg may be tossed anywhere in the target module address
> space depending on the device.
>
> Ideally of course there would be just a standardized range of target
> module related registers at the end of the IO space..
Sorry Tony, but the node address must matchup with the reg description
for the node. I'd rather not sit and argue about this with automated
tools and deal with trivial patches - so either tools like dtc need to
ignore this or lets just fix the node address.
> > > + wkup_uart0: serial@2b300000 {
> >
> > serial@0 to match up with reg?
>
> Yes thanks for catching this. The 8250 IP is at the beginning of the
> target module IO space. Will post an updated patch.
>
> Regards,
>
> Tony
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
