Cristian Ciocaltea wrote: > Add pinmux configuration for DWMAC found on the JH7100 based boards and > enable the related DT node, providing a basic PHY configuration. > > Co-developed-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > Signed-off-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> > --- > .../boot/dts/starfive/jh7100-common.dtsi | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > > diff --git a/arch/riscv/boot/dts/starfive/jh7100-common.dtsi b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi > index 42fb61c36068..5cafe8f5c2e7 100644 > --- a/arch/riscv/boot/dts/starfive/jh7100-common.dtsi > +++ b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi > @@ -72,7 +72,92 @@ wifi_pwrseq: wifi-pwrseq { > }; > }; > > +&gmac { > + pinctrl-names = "default"; > + pinctrl-0 = <&gmac_pins>; > + phy-mode = "rgmii-id"; > + phy-handle = <&phy>; I'm not sure if it's a generic policy or not, but I don't really like adding a reference to a non-existant node here. I'd move this property to the board files where the phy node is actually defined. /Emil