Hi! > Addition of support for the Galaxy Core GC2145 XVGA sensor. > The sensor supports both DVP and CSI-2 interfaces however for > the time being only CSI-2 is implemented. > > Configurations are currently based on initialization scripts > coming from Galaxy Core and so for that purpose only 3 static > resolutions are supported: > - 640x480 > - 1280x720 > - 1600x1200 Also only limited subset of pixel formats is implemented? Would be worth mentioning in the changelog, but perhaps comment at the start of the file would be even better. > +++ b/drivers/media/i2c/Kconfig > @@ -50,6 +50,16 @@ config VIDEO_AR0521 > To compile this driver as a module, choose M here: the > module will be called ar0521. > > +config VIDEO_GC2145 > + select V4L2_CCI_I2C > + tristate "GalaxyCore GC2145 sensor support" > + help > + This is a V4L2 sensor-level driver for GalaxyCore GC2145 > + 2 Mpixel camera. Normally tristate would go before select. Reviewed-by: Pavel Machek <pavel@xxxxxx> (But you probably want to solve the problems reported by the build bot). Thanks and best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
