Hi Tudor, On Thu, 14 Dec 2023 at 10:52, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote: > > The gs101 clock names are derived from the clock register names under > some certain rules. In particular, for the gate clocks the following is > documented and expected in the gs101 clock driver: > > Replace CLK_CON_GAT_CLKCMU with CLK_GOUT_CMU and gout_cmu > Replace CLK_CON_GAT_GATE_CLKCMU with CLK_GOUT_CMU and gout_cmu > > For gates remove _UID _BLK _IPCLKPORT and _RSTNSYNC > > The CMU TOP gate clock names missed to include the required "CMU" > differentiator which will cause name collisions with the gate clock names > of other clock units. Fix the TOP gate clock names and include "CMU" in > their name. > > Fixes: 0a910f160638 ("dt-bindings: clock: Add Google gs101 clock management unit bindings") > Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> [...] Thanks for spotting this inconsistency on the cmu_top gates and fixing it! Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>