Hi Krzysztof, Thanks for your comments. On Thu, 14 Dec 2023 at 09:56, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 13/12/2023 20:05, Tomer Maimon wrote: > > Added device tree binding documentation for Nuvoton BMC NPCM BIOS Post > > Code (BPC). > > > > The NPCM BPC monitoring two configurable I/O addresses written by the > > host on the bus. > > > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > > --- > > .../soc/nuvoton/nuvoton,npcm-bpc.yaml | 65 +++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml > > new file mode 100644 > > index 000000000000..c04302a1d52b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,npcm-bpc.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/nuvoton/nuvoton,npcm-bpc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Nuvoton BMC NPCM BIOS Post Code (BPC) controller > > + > > +maintainers: > > + - Tomer Maimon <tmaimon77@xxxxxxxxx> > > + > > +description: > > + Nuvoton BMC NPCM BIOS Post Code (BPC) monitoring two configurable I/O > > + addresses written by the host on the bus, the capture data stored in > > + 128-word FIFO. > > + > > + NPCM BPC supports capture double words, when using capture > > + double word only I/O address 1 is monitored. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - nuvoton,npcm845-bpc > > + - nuvoton,npcm750-bpc > > + - const: nuvoton,npcm-bpc > > That's not what I suggested. I asked to make 845 compatible with 750. > This works, but I want to be sure you really, really understand the > consequences of this. Did you mean to do the compatible as follows? properties: compatible: items: - enum: - nuvoton,npcm845-bpc - const: nuvoton,npcm750-bpc Appreciate it if you could explain what is the difference between the compatibility suggested in V3? > > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + nuvoton,monitor-ports: > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > Missing constraints, like min/maxItems and maybe values. O.K. > > > + description: > > + Contain monitor I/O addresses on the bus, at least one monitor I/O > > + address required. > > + > > + nuvoton,bpc-en-dwcapture: > > nuvoton,double-word-capture? Modify in V4 > > > + description: > > + Set DWCAPTURE bit in BPCFEN register that enables double word capture > > + according to the first address setting. > > + type: boolean > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - nuvoton,monitor-ports > > Best regards, > Krzysztof > Thanks, Tomer
