This series aims to add support for the display controller (VOP) and the HDMI controller block of RK3128 (which is very similar to the one found in RK3036). The VOP part is very simple - everything we need for HDMI support is already there. I only needed to split the output selection registers from RK3036. The VOP has an IOMMU attached, but it has a serious silicon bug: Registers can only be written, but not be read. As it's not possible to use it with the IOMMU driver in it's current state I'm not adding it here and we have to live with CMA for now - which works fine also. Andy, maybe you can shed a light on whether there is any way to not have to write the registers only and hope for the best (a.k.a rockchip,skip-mmu-read). I have it working here locally - but nothing for upstream (yet). The inno-hdmi driver currently gets a lot of attention [0-2] and I'm hooking in now also. I did only the bare minimum to get a correctly colored picture and a stable signal for RK3128. I leave the cleanups to those other series and will come back with sound/CEC support later. It shouldn't interfere to much, only the csc-part must not get dropped completely and the mode-check-hooks are no longer dead. Note: Patches are based and tested on next-20231213. [0] https://lore.kernel.org/all/20231207-kms-hdmi-connector-state-v5-0-6538e19d634d@xxxxxxxxxx [1] https://lore.kernel.org/all/20231204123315.28456-1-keith.zhao@xxxxxxxxxxxxxxxx [2] https://lore.kernel.org/all/2601b669-c570-f39d-8cf9-bff56c939912@xxxxxxxxx Alex Bee (11): dt-bindings: display: rockchip,inno-hdmi: Document RK3128 compatible drm/rockchip: vop: Add output selection registers for RK312x drm/rockchip: inno_hdmi: Fix video timing drm/rockchip: inno_hdmi: Correctly setup HDMI quantization range drm/rockchip: inno_hdmi: Add variant support drm/rockchip: inno_hdmi: Add RK3128 support drm/rockchip: inno_hdmi: Add basic mode validation drm/rockchip: inno_hdmi: Drop custom fill_modes hook ARM: dts: rockchip: Add display subsystem for RK3128 ARM: dts rockchip: Add HDMI node for RK3128 ARM: dts: rockchip: Enable HDMI output for XPI-3128 .../display/rockchip/rockchip,inno-hdmi.yaml | 30 ++- .../arm/boot/dts/rockchip/rk3128-xpi-3128.dts | 29 +++ arch/arm/boot/dts/rockchip/rk3128.dtsi | 60 ++++++ drivers/gpu/drm/rockchip/inno_hdmi.c | 203 +++++++++++++++--- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 13 +- drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 3 + 6 files changed, 309 insertions(+), 29 deletions(-) base-commit: 48e8992e33abf054bcc0bb2e77b2d43bb899212e -- 2.43.0
