On Wed, Dec 13, 2023 at 10:47:21AM +0100, Mike Looijmans wrote: > Skeleton driver for the TI ADS1298 medical ADC. This device is > typically used for ECG and similar measurements. Supports data > acquisition at configurable scale and sampling frequency. I think the commit subject and body here were accidentally copy-pasted from the driver patch. Patches for bindings should avoid talking about drivers and focus on the harware (unless we are talking about LEDs or motors etc) > > Signed-off-by: Mike Looijmans <mike.looijmans@xxxxxxxx> > > --- > > .../bindings/iio/adc/ti,ads1298.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml > new file mode 100644 > index 000000000000..7a160ba721eb > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1298.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/ti,ads1298.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments' ads1298 medical ADC chips > + > +maintainers: > + - Mike Looijmans <mike.looijmans@xxxxxxxx> > + > +properties: > + compatible: > + enum: > + - ti,ads1298 > + > + reg: > + maxItems: 1 > + > + spi-cpha: true > + > + reset-gpios: > + maxItems: 1 > + > + avdd-supply: > + description: > + Analog power supply, voltage between AVDD and AVSS. When providing a > + symmetric +/- 2.5V, the regulator should report 5V. > + > + vref-supply: > + description: > + Optional reference voltage. If omitted, internal reference is used, > + depending on analog supply this is 2.4 or 4V. It may be worth mentioning here what the conditions for the internal reference being 2.4 or 4 volts actually are. > + > + clocks: > + description: Optional 2.048 MHz external source clock on CLK pin > + maxItems: 1 > + > + clock-names: > + const: clk Since you have only one clock, having clock-names (especially with a name like "clk") is pointless IMO. Generally though, this patch looks good to me. Cheers, Conor. > + interrupts: > + description: Interrupt on DRDY pin, triggers on falling edge > + maxItems: 1 > + > + label: true > + > +required: > + - compatible > + - reg > + - avdd-supply > + - interrupts > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@1 { > + reg = <1>; > + compatible = "ti,ads1298"; > + label = "ads1298-1-ecg"; > + avdd-supply = <®_iso_5v_a>; > + clock-names = "clk"; > + clocks = <&clk_ads1298>; > + interrupt-parent = <&gpio0>; > + interrupts = <78 IRQ_TYPE_EDGE_FALLING>; > + spi-max-frequency = <20000000>; > + spi-cpha; > + }; > + }; > +... > -- > 2.34.1 > > > Met vriendelijke groet / kind regards, > > Mike Looijmans > System Expert > > > TOPIC Embedded Products B.V. > Materiaalweg 4, 5681 RJ Best > The Netherlands > > T: +31 (0) 499 33 69 69 > E: mike.looijmans@xxxxxxxx > W: www.topic.nl > > Please consider the environment before printing this e-mail
Attachment:
signature.asc
Description: PGP signature