Emil Renner Berthing wrote: > Sia Jee Heng wrote: > > Add initial device tree for the StarFive JH8100 RISC-V SoC. > > > > Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx> > > Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx> > > Looks good to me, thanks. > > Acked-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> I just learned that this JH8100 is not actually a real SoC yet but just an FPGA implementation, and no indication that that's actually a product that will be mass produced. Hence a lot of details may change before it becomes a real SoC/product people can buy, so let's not add this device tree yet before everything is set in silicon. Please consider my Acked-by abeve revoked. Sia Jee Heng: With that said I still think it's super awesome that you're beginning upstreaming support for your new SoCs early. I wish more SoC vendors would follow your example. /Emil