On 12/12/2023 17:39, Ninad Palsule wrote: > From: Andrew Geissler <geissonator@xxxxxxxxx> > > Add a device tree for IBM system1 BMC board. It uses AST2600 SOC. > > Tested: > This board is tested using the simics simulator. > > Signed-off-by: Andrew Geissler <geissonator@xxxxxxxxx> > Signed-off-by: Ninad Palsule <ninad@xxxxxxxxxxxxx> > --- > arch/arm/boot/dts/aspeed/Makefile | 1 + > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 188 ++++++++++++++++++ > 2 files changed, 189 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > > diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile > index 3e3e6b96cb79..6f7ed11978ff 100644 > --- a/arch/arm/boot/dts/aspeed/Makefile > +++ b/arch/arm/boot/dts/aspeed/Makefile > @@ -35,6 +35,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-ibm-rainier.dtb \ > aspeed-bmc-ibm-rainier-1s4u.dtb \ > aspeed-bmc-ibm-rainier-4u.dtb \ > + aspeed-bmc-ibm-system1.dtb \ > aspeed-bmc-intel-s2600wf.dtb \ > aspeed-bmc-inspur-fp5280g2.dtb \ > aspeed-bmc-inspur-nf5280m6.dtb \ > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > new file mode 100644 > index 000000000000..01291b407f59 > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts > @@ -0,0 +1,188 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2023 IBM Corp. > +/dts-v1/; > + > +#include "aspeed-g6.dtsi" > +#include <dt-bindings/gpio/aspeed-gpio.h> > +#include <dt-bindings/i2c/i2c.h> > +#include <dt-bindings/leds/leds-pca955x.h> > + > +/ { > + model = "System1"; > + compatible = "ibm,system1-bmc", "aspeed,ast2600"; > + > + chosen { > + stdout-path = &uart5; > + bootargs = "console=ttyS4,115200n8 earlycon"; Drop early con, debugging feature not release. Then use stdout path alone, so drop console as well. > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x40000000>; > + }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + event_log: tcg_event_log@b3d00000 { No underscores in node names. Best regards, Krzysztof