Hi Rob, Thank you for the review. >> diff --git a/drivers/phy/realtek/phy-rtk-pcie.c >> b/drivers/phy/realtek/phy-rtk-pcie.c >> new file mode 100644 >> index 000000000000..8ec845890271 >> --- /dev/null >> +++ b/drivers/phy/realtek/phy-rtk-pcie.c >> @@ -0,0 +1,738 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later >> +/* >> + * Realtek DHC PCIe PHY driver >> + * >> + * Copyright (c) 2023 Realtek Semiconductor Corp. >> + */ >> + >> +#include <linux/mfd/syscon.h> >> +#include <linux/module.h> >> +#include <linux/nvmem-consumer.h> >> +#include <linux/of_address.h> >> +#include <linux/of_device.h> > >You probably don't need this header and the implicit includes it makes are >dropped now in linux-next. Please check what you actually need and make >them explicit. > >of_address.h is likely not needed either. Please check. > >Rob I will check and revise it. Thanks, Tzuyi Chang
