On Tue, Nov 28, 2023 at 11:44 PM James Tai <james.tai@xxxxxxxxxxx> wrote: > > Add support for the RTD1319 platform. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202311061208.hJmxGqym-lkp@xxxxxxxxx/ > CC: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > CC: Marc Zyngier <maz@xxxxxxxxxx> > CC: linux-kernel@xxxxxxxxxxxxxxx > Signed-off-by: James Tai <james.tai@xxxxxxxxxxx> > --- > v2 to v3 change: > - Unchanged > > v1 to v2 change: > - Resolved kernel test robot build warnings > - Replaced magic number with macro > - Fixed code style issues > > drivers/irqchip/Kconfig | 6 + > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-realtek-rtd1319.c | 218 ++++++++++++++++++++++++++ > 3 files changed, 225 insertions(+) > create mode 100644 drivers/irqchip/irq-realtek-rtd1319.c > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 267c3429b48d..05856ce885fa 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -222,6 +222,12 @@ config REALTEK_DHC_INTC > tristate > select IRQ_DOMAIN > > +config REALTEK_RTD1319_INTC > + tristate "Realtek RTD1319 interrupt controller" > + select REALTEK_DHC_INTC > + help > + Support for Realtek RTD1319 Interrupt Controller. > + > config RENESAS_INTC_IRQPIN > bool "Renesas INTC External IRQ Pin Support" if COMPILE_TEST > select IRQ_DOMAIN > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index f6774af7fde2..6a2650b0a924 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -48,6 +48,7 @@ obj-$(CONFIG_IXP4XX_IRQ) += irq-ixp4xx.o > obj-$(CONFIG_JCORE_AIC) += irq-jcore-aic.o > obj-$(CONFIG_RDA_INTC) += irq-rda-intc.o > obj-$(CONFIG_REALTEK_DHC_INTC) += irq-realtek-intc-common.o > +obj-$(CONFIG_REALTEK_RTD1319_INTC) += irq-realtek-rtd1319.o > obj-$(CONFIG_RENESAS_INTC_IRQPIN) += irq-renesas-intc-irqpin.o > obj-$(CONFIG_RENESAS_IRQC) += irq-renesas-irqc.o > obj-$(CONFIG_RENESAS_RZA1_IRQC) += irq-renesas-rza1.o > diff --git a/drivers/irqchip/irq-realtek-rtd1319.c b/drivers/irqchip/irq-realtek-rtd1319.c > new file mode 100644 > index 000000000000..23c13c218b04 > --- /dev/null > +++ b/drivers/irqchip/irq-realtek-rtd1319.c > @@ -0,0 +1,218 @@ > +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +/* > + * Realtek RTD1319 interrupt controller driver > + * > + * Copyright (c) 2023 Realtek Semiconductor Corporation > + */ > + > +#include <linux/init.h> > +#include <linux/io.h> > +#include <linux/irqchip.h> > +#include <linux/of_device.h> You probably don't need this header and the implicit includes it makes are dropped now in linux-next. Please check what you actually need and make them explicit. Rob
