On Sun, Dec 10, 2023 at 04:27:16AM +0000, Xu Yang wrote: > Hi Conor, > > > On Fri, Dec 08, 2023 at 04:53:59PM +0800, Xu Yang wrote: > > > i.MX95 has a DDR pmu. This will add a compatible for it. > > > > On v1 we had a discussion because the commit message wasn't clear about > > whether or not the device was compatible with existing ones. For some > > reason, the v2 patch _removes_ information from the commit message > > rather than tries to explain. > > This [1] message of yours, that I didn't get a chance to reply to before > > you sent this new version, seems to say that there should be an > > imx93-ddr-pmu fallback. > > Thanks for your comments. > > Just read my previous comment in [1] and found I made a mistake. > Now I'll try to clarify it here. > > Imx95 and imx93 have different AXI filter configuration. I need a > compatible for imx95 since the driver cannot differentiate them. > > Then I need to consider below two options: > 1. compatible = "fsl,imx95-ddr-pmu", "fsl,imx93-ddr-pmu" > 2. compatible = "fsl,imx95-ddr-pmu" > > Both of them work correctly on imx95. When I make changes in > driver for imx95, imx93 is not affected. > > For basic functions, imx95 is compatible with imx93. I select the 2rd > form for simplicity. If the first form is optimal, I can change it in next > version. The first form is preferred, yes.
Attachment:
signature.asc
Description: PGP signature
